Repository navigation
ci: ignore co-author trailers in commitlint's footer length check - #22
Merged
Merged
Conversation
Squash-merging a release PR adds a Co-authored-by trailer for the App that wrote its pin commit. The App's noreply address makes that line 110 characters, so commitlint failed on main for both release commits (v7.0.0 and v7.1.0). PR checks lint each commit separately and never see the trailer. footer-max-line-length becomes a function rule, like the body rule beside it, that skips Co-authored-by lines and still fails any other footer line over 100 characters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commitlint failed on
mainfor both release commits, v7.0.0 (aab35a7) and v7.1.0 (8008080) (e.g. run 43062767836). Squash-merging a release PR adds aCo-authored-by: semantic-release-pusher[bot] <…@users.noreply.github.com>trailer for the App that wrote the pin commit, and that line is 110 characters againstfooter-max-line-length's 100. PR checks lint each commit on its own, so the trailer only appears once the squash lands onmain.footer-max-line-lengthbecomes a function rule, alongside the existing body rule, that skipsCo-authored-by:lines and applies the 100-character limit to the rest of the footer.Checked with
@commitlint/load+@commitlint/linton Node 26.13.0:aab35a7(release 7.0.0)8008080(release 7.1.0)f609007,f024f3b,bfc461dCo-authored-by:trailerRefs:footer🤖 Generated with Claude Code